Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureComms: Add support for inbound network namespace #2048

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

davidhadas
Copy link
Member

@davidhadas davidhadas commented Sep 21, 2024

See:

@davidhadas davidhadas requested a review from a team as a code owner September 21, 2024 18:55
@davidhadas davidhadas force-pushed the secComms_netNs branch 2 times, most recently from b6662c0 to 0bb9a73 Compare September 26, 2024 12:44
@davidhadas davidhadas changed the title SecureComms: Add support for inbound namespace SecureComms: Enhancements (inbound namespace and deamonConfig control) Sep 26, 2024
@davidhadas davidhadas force-pushed the secComms_netNs branch 4 times, most recently from a09eb6b to 3caa67e Compare September 26, 2024 17:36
@davidhadas davidhadas changed the title SecureComms: Enhancements (inbound namespace and deamonConfig control) SecureComms: Add support for inbound network namespace Sep 26, 2024
@davidhadas davidhadas force-pushed the secComms_netNs branch 2 times, most recently from 85a4725 to 3ce165c Compare September 27, 2024 05:00
@bpradipt bpradipt requested a review from yoheiueda September 27, 2024 06:43
@davidhadas davidhadas force-pushed the secComms_netNs branch 3 times, most recently from a2eb53b to 839c9d7 Compare October 2, 2024 13:11
Copy link
Member

@yoheiueda yoheiueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much!

@davidhadas
Copy link
Member Author

cc: @bpradipt

@davidhadas davidhadas force-pushed the secComms_netNs branch 4 times, most recently from 0761631 to e759430 Compare October 30, 2024 12:31
@davidhadas davidhadas self-assigned this Oct 30, 2024
@davidhadas davidhadas force-pushed the secComms_netNs branch 2 times, most recently from 716d98c to 786081c Compare October 31, 2024 08:16
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @davidhadas

Support opening inbound ports in configrable network namespaces.
This allows opening an inbound port inside the pod network namespace of the podvm.
The traffic will be forwarded via the SecureComms ssh channel to the outbound at the worker node.

Signed-off-by: David Hadas <[email protected]>
@davidhadas davidhadas merged commit 8e08587 into confidential-containers:main Nov 8, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants